[PATCH] vi read-only mode bugfix and enhancement

Denis Vlasenko vda.linux at googlemail.com
Sat Jul 14 22:37:50 UTC 2007


On Saturday 14 July 2007 21:45, Natanael Copa wrote:
> On Fri, 2007-07-13 at 16:57 +0100, Denys Vlasenko wrote:
> > > Original vim shows "permission denied" but "Read-only" is better than
> > > nothing.
> > 
> > Nice. Any chance getting "[Read failed]" (or whatever non-puzzling msg)
> > so we don't need to return to this once more?
> 
> Code is messy and unreadable and even small changes tend to require
> redesign. (there are 3 different way how files are read and all 3 are
> handled different)
> 
> I think maybe I should start with renaming the global vars. What does
> "cfn" mean?

On the positive side, it's not that bad. It could have been named "_".

> Yes. I want this so bad so I spent some time to be able to add the
> feature and reduce size at the same time to increase my chances to get
> that specific feature in.
> 
> I can make it a config option if you want, but for -12 bytes i thought I
> could get it for free ;-)

No, 12 bytes is ok. Applied to svn as-is. Thanks.
--
vda



More information about the busybox mailing list