[PATCH] on lease/pid-file for udhcpd/c

[Denis Vlasenko]

On Friday 29 June 2007 21:22, Mats Erik Andersson wrote:
> Hello all,
>         
>         I was getting annoyed at the reluctance of udhcpd to
>         volontarily update its lease file when a new lease has
>         been granted. The attached patch introduces a configuration
>         entry for Busybox 1.6.0 to write a new copy of the lease
>         file immediately when it has sent DHCPACK.

I will apply this part. Thanks!

>         It took me some time to figure it out, but starting with
>         Busybox 1.6.0 there is a new entry FEATURE_PIDFILE, which when
>         forgotten causes udhcpc to complain about missing pidfile as
>         soon as one tries to release the device. To avoid that serious
>         malfunction I strongly suggest an addition to
>         networking/udhcp/Config.in:
>         
>            config APP_UDHCPC
>              ...
>                 select FEATURE_PIDFILE

I'd rather make it stop checking for pidfile if FEATURE_PIDFILE!=y.
Can you describe in more detail (on source code level) where it complains?

>         The attached diff-file is bold enough to take care of
>         both matters.

+#ifdef ENABLE_FEATURE_UDHCPD_WRITE_LEASES_EARLY
+       // Rewrite the file with leases at every new acceptance
+       write_leases();
+#endif

ENABLE_FEATURE_UDHCPD_WRITE_LEASES_EARLY is always defined (to 1 or 0).
You have to use #if, not #ifdef.
--
vda