ether-wake does not compile with "-Werror"

[Rob Landley]

On Saturday 27 January 2007 6:17 pm, Denis Vlasenko wrote:
> > I think this is a bad idea.  I think having -Werror in release versions 
(not 
> > just development versions) is an extremely very bad idea.  But if that's 
your 
> > policy, then #warning means #error and it should say so.
> 
> I made -Werror configurable.

Hmmm...

I originally put -Werror in because without it, warnings kept accumulating in 
the development kernel, checked in by people who should have known 
better.  -Werror meant that it hit them, and that thus got fixed.  If it 
didn't default to -Werror, you couldn't yell at them loudly about "you broke 
the build", and they'd just keep doing it expecting other people to clean 
them up later.

That said, I took it out of releases (by hand, along with updating the version 
number) because people out in the world shouldn't be forced to deal with 
that.

Making it configurable makes a certain amount of sense, but if you take it out 
of defconfig for -devel, expect warnings to accumulate in the tree again.  
And if you leave it in defconfig for releases, expect poor confused users to 
crop on the list. :)

Rob
-- 
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery