busybox stty -echo

[Bernhard Fischer]

On Fri, Jan 12, 2007 at 04:46:33PM -0500, Paul Albrecht wrote:
>
>I typedef'ed int to smallint at the start of stty_main and the applet
>compiled cleanly.
>
>I tested "busybox stty -echo" with the updated busybox and it worked,
>that is, echoing was turned off, so your fix works for me.
>
>Thanks!

Paul, all,

May i ask you to test the attached patches?

They were only compile tested but shouldn't do much harm, except,
perhaps the busybox.stty-01g-shrinkage.diff

statistics:
   text	   data	    bss	    dec	    hex	filename
   6714	      8	     14	   6736	   1a50	stty.o.orig
   6599	      8	     14	   6621	   19dd	stty.o.01b
   6599	      8	     14	   6621	   19dd	stty.o.01c
   6599	      8	     14	   6621	   19dd	stty.o.01d
   6517	      8	     14	   6539	   198b	stty.o.01e
   6462	      8	     14	   6484	   1954	stty.o.01f
   6203	      8	     14	   6225	   1851	stty.o.01g
   6197	      8	     14	   6219	   184b	stty.o.01h
   6197	      8	     14	   6219	   184b	stty.o.01i

ChangeLog:

busybox.stty-01b-shrinkage.diff:
- reuse option_mask32 for state-handling in main
- improve check for errors from fcntl


busybox.stty-01c-shrinkage.diff:
- constify some read-only members and remove superfluous casts
  (cleanup)

busybox.stty-01d-shrinkage.diff:
- manually inline tty_value_to_baud and remove string_to_baud_or_die
  (cleanup)

busybox.stty-01e-shrinkage.diff:
- rewrite find_param to use index_in_str_array

busybox.stty-01f-shrinkage.diff:
- peruse get_terminal_width_height and remove legacy code for ancient
  slowaris versions.

busybox.stty-01g-shrinkage.diff:
- merge display_changed() and display_all()

busybox.stty-01h-shrinkage.diff:
- reuse return code of vsnprintf to avoid pulling in strlen

busybox.stty-01i-shrinkage.diff:
- remove superfluous define that expanded to "!strcmp"
- remove some dead code


I will apply these patches to trunk in about a week unless somebody objects.

thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01b-shrinkage.diff
Type: text/x-diff
Size: 6265 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0008.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01c-shrinkage.diff
Type: text/x-diff
Size: 2068 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0009.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01d-shrinkage.diff
Type: text/x-diff
Size: 1462 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0010.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01e-shrinkage.diff
Type: text/x-diff
Size: 865 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0011.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01f-shrinkage.diff
Type: text/x-diff
Size: 3279 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0012.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01g-shrinkage.diff
Type: text/x-diff
Size: 4693 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0013.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01h-shrinkage.diff
Type: text/x-diff
Size: 545 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0014.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.stty-01i-shrinkage.diff
Type: text/x-diff
Size: 2165 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070114/66c2cfcc/attachment-0015.bin