Does it make sense to reduce bss?

[Denis Vlasenko]

Hi,

Current svn with all options on has ~85k in bss. It is not a problem
for MMU systems but NOMMU, I suppose, would benefit from smaller bss.

I was removing largish bss users and mostly fixed big ones,
but should I go after not-so-big ones too?

For example:

Attached patch moves 8k of fsck_minix's buffers from bss to xzalloc'ed
space, but it costs ~150 bytes of code:

function                                             old     new   delta
recursive_check2                                    1382    1451     +69
recursive_check                                     1169    1207     +38
check_zones                                          214     240     +26
check_zones2                                         231     253     +22
add_zone_ind2                                         81     102     +21
add_zone_ind                                          81     102     +21
add_zone_dind2                                        81     102     +21
add_zone2                                            216     223      +7
add_zone                                             215     222      +7
blockbuf                                               -       4      +4
write_block                                          594     592      -2
check_zone_nr2                                       119     117      -2
die                                                   46      40      -6
write_super_block                                    117     106     -11
fsck_minix_main                                     4035    3990     -45
super_block_buffer                                  2048    1024   -1024
static.blk                                          7168       -   -7168
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 11/6 up/down: 251/-8258)      Total: -8022 bytes

Opinions?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d.patch
Type: text/x-diff
Size: 5352 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070103/3945bdcc/attachment-0001.bin