[PATCH] fix httpd lockup in cgi POSTs

Denis Vlasenko vda.linux at googlemail.com
Sun Feb 11 13:07:25 PST 2007


On Sunday 11 February 2007 20:38, Matthias Reichl wrote:
> While debugging some lockup problems with the openwrt webif^2 firmware
> upload page I discovered a bug in httpd.c:
> 
> In line 1216 it must really be safe_read(), not full_read().
> Otherwise httpd may lock up in the case where the cgi-script
> has sent some data before fully receiving all POSTed data.
> 
> httpd.c multiplexes fine using select() and only calls safe_read()
> if data is available, whereas full_read() loops over safe_read()
> without checking if data is available. In this case read() will
> block...

Thanks, this was fixed just minutes ago. Please test whether
current svn works for you.
--
vda


More information about the busybox mailing list