svn commit: trunk/busybox/shell

Denis Vlasenko vda.linux at googlemail.com
Sun Apr 15 11:51:53 UTC 2007


On Sunday 15 April 2007 12:18, Mike Frysinger wrote:
> > -		if (some_really_long_checks && some_other_really_long_checks \
> > -		    && some_more_really_long_checks)
> > -		{
> > +		if (some_really_long_checks && some_other_really_long_checks
> > +		 && some_more_really_long_checks
> > +		 && even_more_of_long_checks
> > +		) {
> 
> personally i think the former is better than the latter as my eyes tend to 
> pick out the scope brackets {} rather than function/grouping parens ()

Let me think about it...

> > +Then have long options defined:
> > +
> > +	static const struct option <applet>_long_options[] = {
> > +		{ "list",    0, NULL, 't' },
> > +		{ "extract", 0, NULL, 'x' },
> > +		{ NULL }
> > +	};
> 
> i want to say { NULL, 0, NULL, 0 } prevents warnings that { NULL } causes, but 
> i could just be pulling this out of my ass ...

I fixed this text, thanks.
--
vda



More information about the busybox mailing list