patch for touch.c v1.4.2

Robin Farine robin.farine at terminus.org
Tue Apr 10 00:56:55 PDT 2007


Hi,

On Tue April 10 2007 01:48, Larry Brigman wrote:
> When Wall is on busybox config also turns on Werror.  Because of
> this touch causes the make to fail because of invalid NULL
> parameter.
>
> This patch fixes the problem.

Hmm, I think it introduces a bug since utime's semantics depends on 
whether the second argument is NULL or not. If it is not NULL but 
points to an uninitialized instance of struct utimbuf, utime will 
probably have some strange effects :-).

It looks like the real problem lies in the compiler, NULL is 
perfectly valid here. What warning does the compiler spit out?

Robin


More information about the busybox mailing list