[PATCH] Integrate dd ibs/obs patch

Paul Fox pgf at brightstareng.com
Tue May 30 21:42:12 UTC 2006


rob landley wrote:
 > On Tuesday 16 May 2006 4:50 am, Rob Sullivan wrote:
 > > The attached patch adds ibs= and obs= support to dd, based on the patch in
 > > the patches/ subdirectory. It makes the feature optional, as requested a
 > > while ago.
 > 
 > Hmmm...  If somebody specifies both obs= and bs= they can cause the size to be 
 > something that the !twobufs_flag codepath doesn't expect.  I'll fix it.  (And 
 > the #ifdefs are going away; The !twobufs_flag codepath should be the same 
 > whether the twobufs part is enabled or not.)
 > 
 > conv= should be under this config flag as well.

i don't understand the last part of this change.

why are the "notrunc" and "noerror" conv options conditional on
the FEATURE_DD_IBS_OBS?

i can separate them, if it's the right thing -- i have another
conv= option i'd like to add, and it's definitely independent of
ibs/obs, so i need to clean this up for my own use in any case.

paul
=---------------------
 paul fox, pgf at brightstareng.com



More information about the busybox mailing list