sed and llist

[Rob Landley]

On Wednesday 24 May 2006 5:53 am, Bernhard Fischer wrote:
> Rob,
>
> Can you please correct this in svn?
> TIA and cheers,

Got it.  Thanks.

(Otherwise still taking a forced break from busybox development, probably all 
this week.  Sigh...)

Rob

> On Fri, May 19, 2006 at 09:27:16PM +0200, Yann E. MORIN wrote:
> >Hello all!
> >
> >sed calls an non-existing llist_free_contents function.
> >
> >The contents of the list are char* allocated with bb_xstrdup, so should be
> >freed with free(3). Am I right here?
> >
> >Here is a patch against trunk to solve this by calling llist_free with
> > freeit set to free(3).
> >
> >Regards,
> >Yann E. MORIN.
> >
> >--
> >.-----------------.--------------------.------------------.---------------
> >-----.
> >
> >|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> >| conspiracy: | +0/33 662376056 | Software  Designer | \ / CAMPAIGN     | 
> >|  ^                | --==< °_° >==-- °---.----------------:  X  AGAINST  
> >|    |  /e\  There is no  | web: ymorin.free.fr | SETI at home 3808 | / \
> >| HTML MAIL    |  """  conspiracy.  |
> >
> >°---------------------°----------------°------------------°---------------
> >-----°
> >
> >Index: busybox-llist-void/editors/sed.c
> >===================================================================
> >--- busybox-llist-void/editors/sed.c	(revision 15140)
> >+++ busybox-llist-void/editors/sed.c	(working copy)
> >@@ -134,7 +134,7 @@
> > {
> > 	sed_cmd_t *sed_cmd = bbg.sed_cmd_head.next;
> >
> >-	llist_free_contents(bbg.append_head);
> >+	llist_free(bbg.append_head, free);
> >
> > 	while (sed_cmd) {
> > 		sed_cmd_t *sed_cmd_next = sed_cmd->next;
> >
> >_______________________________________________
> >busybox mailing list
> >busybox at busybox.net
> >http://busybox.net/cgi-bin/mailman/listinfo/busybox

-- 
Never bet against the cheap plastic solution.