proposal to start merging some source files in libbb/

Robert P. J. Day rpjday at mindspring.com
Thu May 18 10:16:18 PDT 2006


  just before i head for the gym, a repeat of a thought i had a couple
months back.  it seems that there's just too many trivial source files
in libbb/, and some of them could be merged and be even more
meaningful afterwards.

  as a trivial example,

	create_icmp_socket.c
	create_icmp6_socket.c

those files each define a single function, and have common includes,
so it would save disk space to just place both of them in the same
file (create_icmp_socket.c?), remove the other file, and adjust
Makefile.in accordingly.

  as another example, how about xgethostbyname*.c?  it's hard to
defend a separate source file for a 5-line function, so do the same
thing there.  i don't see any overwhelming downside to this -- it at
least lets me see related library functions by looking at just one
source file.

  thoughts?

rday


More information about the busybox mailing list