[PATCH/RFC] bb_maybe_free() and bb_maybe_close()

Rob Landley rob at landley.net
Mon Mar 13 15:58:27 UTC 2006


On Monday 13 March 2006 2:08 am, Denis Vlasenko wrote:
> Hi Rob,
>
> This patch does not result in any difference in generated code.
> But maybe you will find it nicer wrt code readability.
>
> Aplly if you like it.

Um, no thanks.  This was brought up before and I don't really think it's an 
improvement.

I did notice several chunks of code that test for non-null before calling free 
(which isn't required), but I'm not too bothered about them since they're 
behind FEATURE_CLEAN_UP guards, which is a debug feature at present...

> --
> vda

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list