revision 14457: make 3.79 ok, 3.80 unhappy

Thu Mar 9 17:38:55 UTC 2006

On Wed, Mar 08, 2006 at 06:24:45PM +0100, Bernhard Fischer wrote:
>[resending this with bzip2'ed attachment. Sorry if you receive this
>twice]
>
>On Tue, Mar 07, 2006 at 06:56:56PM -0500, Rob Landley wrote:
>>On Tuesday 07 March 2006 1:26 pm, Jason Schoon wrote:
>>> Works great on my previously non-working Slackware with vanilla 3.80.
>>> Thanks Bernhard.
>>
>>Just built fine for me on Ubuntu and on Red Hat 9.
>
>updated patch against current svn which also takes into account
>that make-3.79.1 doesn't support $(eval ).
>
>I intend to apply this, so please give it a whirl..

Checked in as r14477.

If someone wants to compile e2fsprogs with make from the 3.81 series
he should copy the workaround for 3.81beta4 in e2fsprogs/Makefile.in
(also see http://busybox.net/lists/busybox/2006-March/019137.html)

I'm not 100% sure if this is really a bug in make or not, but it very
much looks like to me. Vapier may now more (as he did add e2fsprogs and
also this Makefile.in).
>
>defconfig-tested with
>make-3.79.1 (RH9): ok
>make-3.80 (RH AS4.2): ok Â¹)
>make-3.80 (SuSE): ok Â²)
>make-3.80 (Ubuntu): ok Â³)

and of course
make-3.80 vanilla: ok
>
>Some warnings from the different machines are below, in case someone
>feels like silencing one or the other..
>
>diffstat:
> Makefile                           |  122
>++++++++++---------------------------
> Rules.mak                          |   56 +++++++++-------
> applets/Makefile.in                |    8 +-
> archival/Makefile.in               |    8 +-
> archival/libunarchive/Makefile.in  |    8 +-
> console-tools/Makefile.in          |    8 +-
> coreutils/Makefile.in              |    8 +-
> coreutils/libcoreutils/Makefile.in |    9 ++
> debianutils/Makefile.in            |    8 +-
> e2fsprogs/Makefile.in              |   45 +++++++++++--
> editors/Makefile.in                |    8 +-
> findutils/Makefile.in              |    8 +-
> init/Makefile.in                   |    8 +-
> libbb/Makefile.in                  |    9 ++
> libpwdgrp/Makefile.in              |    8 +-
> loginutils/Makefile.in             |    8 +-
> miscutils/Makefile.in              |    8 +-
> modutils/Makefile.in               |    8 +-
> networking/Makefile.in             |    8 +-
> networking/libiproute/Makefile.in  |    9 +-
> networking/udhcp/Makefile.in       |    8 +-
> procps/Makefile.in                 |    8 +-
> shell/Makefile.in                  |    8 +-
> sysklogd/Makefile.in               |    8 +-
> util-linux/Makefile.in             |    8 +-
> 25 files changed, 236 insertions(+), 166 deletions(-)
>
>Â¹)
>/obj/bb/e2fsprogs/blkid/probe.c:489: warning: initialization
>from incompatible pointer type
>/obj/bb/e2fsprogs/blkid/probe.c:490: warning: initialization
>from incompatible pointer type
>/obj/bb/e2fsprogs/blkid/probe.c:509: warning: initialization
>from incompatible pointer type
>/obj/bb/e2fsprogs/ext2fs/ext2fs_inline.c: In function
>`ext2fs_resize_mem':
>/obj/bb/e2fsprogs/ext2fs/ext2fs_inline.c:50: warning: implicit
>declaration of function `memcpy'
>
>Â²) same as RH AS plus the usual
>/tmp/bb/networking/libiproute/ipaddress.c: In function
>`ipaddr_list_or_flush':
>/tmp/bb/networking/libiproute/ipaddress.c:509: warning:
>declaration of `round' shadows a global declaration
><built-in>:0: warning: shadowed declaration is here
>and
>/tmp/bb/util-linux/readprofile.c: In function
>`readprofile_main':
>/tmp/bb/util-linux/readprofile.c:246: warning: long long
>unsigned int format, long unsigned int arg (arg 2)
>
>
>Â³)
>gcc-4.1.0:
>/scratch/src/bb/e2fsprogs/Makefile.in:107: FIXME: change .c to include
>their stuff relative to /scratch/src/bb/e2fsprogs
>/scratch/src/bb/networking/ping6.c: In function 'unpack':
>/scratch/src/bb/networking/ping6.c:302: warning: type-punning to
>incomplete type might break strict-aliasing rules
>/scratch/src/bb/networking/ping6.c: In function 'ping':
>/scratch/src/bb/networking/ping6.c:383: warning: type-punning to
>incomplete type might break strict-aliasing rules
>/scratch/src/bb/networking/libiproute/iplink.c: In function 'do_iplink':
>/scratch/src/bb/networking/libiproute/iplink.c:252: warning: 'htype' may
>be used uninitialized in this function
>/scratch/src/bb/coreutils/uudecode.c: In function 'uudecode_main':
>/scratch/src/bb/coreutils/uudecode.c:143: warning: 'decode_fn_ptr' may
>be used uninitialized in this function
>/scratch/src/bb/e2fsprogs/blkid/read.c: In function 'blkid_read_cache':
>/scratch/src/bb/e2fsprogs/blkid/read.c:298: warning: 'name' may be used
>uninitialized in this function
>/scratch/src/bb/util-linux/nfsmount.c: In function 'xdr_mountres3_ok':
>/scratch/src/bb/util-linux/nfsmount.c:997: warning: dereferencing
>type-punned pointer will break strict-aliasing rules
>/scratch/src/bb/procps/fuser.c: In function 'fuser_main':
>/scratch/src/bb/procps/fuser.c:146: warning: 'tmp_dev' may be used
>uninitialized in this function
>/scratch/src/bb/procps/fuser.c:316: warning: 'proto' may be used
>uninitialized in this function
>/scratch/src/bb/e2fsprogs/e2fsck.c: In function
>'adjust_extattr_refcount':
>/scratch/src/bb/e2fsprogs/e2fsck.c:5300: warning: 'count' may be used
>uninitialized in this function
>/scratch/src/bb/e2fsprogs/ext2fs/ext2fs_inline.c: In function
>'ext2fs_resize_mem':
>/scratch/src/bb/e2fsprogs/ext2fs/ext2fs_inline.c:50: warning: implicit
>declaration of function 'memcpy'
>/scratch/src/bb/e2fsprogs/ext2fs/ext2fs_inline.c:50: warning:
>incompatible implicit declaration of built-in function 'memcpy'
>/scratch/src/bb/shell/ash.c: In function 'letcmd':
>/scratch/src/bb/shell/ash.c:12526: warning: 'i' may be used
>uninitialized in this function
>/scratch/src/bb/libbb/copy_file.c: In function 'copy_file':
>/scratch/src/bb/libbb/copy_file.c:124: warning: 'dst_fd' may be used
>uninitialized in this function
>
>gcc-trunk:
>/scratch/src/bb/coreutils/comm.c: In function 'cmp_files':
>/scratch/src/bb/coreutils/comm.c:78: warning: the address of 'thisline',
>will always evaluate as 'true'
>/scratch/src/bb/coreutils/comm.c:85: warning: the address of 'thisline',
>will always evaluate as 'true'
>/scratch/src/bb/coreutils/uudecode.c: In function 'uudecode_main':
>/scratch/src/bb/coreutils/uudecode.c:143: warning: 'decode_fn_ptr' may
>be used uninitialized in this function
>/scratch/src/bb/coreutils/sort.c: In function 'get_key':
>/scratch/src/bb/coreutils/sort.c:61: warning: 'end' may be used
>uninitialized in this function
>/scratch/src/bb/shell/ash.c: In function 'letcmd':
>/scratch/src/bb/shell/ash.c:12526: warning: 'i' may be used
>uninitialized in this function
>/scratch/src/bb/networking/ping6.c: In function 'unpack':
>/scratch/src/bb/networking/ping6.c:302: warning: type-punning to
>incomplete type might break strict-aliasing rules
>/scratch/src/bb/networking/ping6.c: In function 'ping':
>/scratch/src/bb/networking/ping6.c:383: warning: type-punning to
>incomplete type might break strict-aliasing rules
>