is NFS mounting borked in bb-1.1.1?

[Rob Landley]

On Thursday 30 March 2006 2:16 am, Kumar Gala wrote:
> > No, when we hit the end of the list, getmntent_r() should return 0,
> > which goes
> > through into the test with the comment "Were we looking for something
> > specific?", which is for optind != argc, and then makes use of
> > mtnext...
>
> Ok, now I think I understand the issue.  While the pointer swapping
> between mtcur and mtnext works, these data structures contain
> pointers that point into bb_common_bufsiz1.  One find a match, swap
> mtcur & mtnext.  Once we call getmntent_r we end up changing
> bb_common_bufsiz1 which means whatever mtnext points out is now bogus.
>
> So when we swap mtnext/mtcur we also need to swap bb_common_bufsiz1
> to another buffer.  Is there another standard buffer we can use?

Doh!

I was allocating a big buffer on the stack and doing a +offset thing at one 
point, but that apparently that got dropped when I moved it to 
bb_common_bufsiz1.  (Which is another horrible name, by the way.)

Yeah, that's an obvious bug.  Good catch.  I'll fix that tonight...

> - kumar

Rob
-- 
Never bet against the cheap plastic solution.