[Patch] Fix zcip timeouts...

Paul Fox pgf at brightstareng.com
Wed Mar 29 15:02:56 PST 2006


reviewed and applied.  thanks for that, and for the pointer to
the kernel patch.  i was unaware of that.

paul

 > The problem is that if the zcip protocol times out at about the same 
 > time another ARP packet is being received, the newly calculated timeout 
 > may be set to wait forever.  This prevents the protocol from progressing 
 > through its various states.
 > 
 > The Fix is to set the timeout to zero if it used to be a positive 
 > number, but it has already expired.  This causes the next protocol state 
 > to be entered immediately instead of never.
 > 
 > If OK please commit.
 > 
 > Also note that if you may have to apply the patch on this page:
 > 
 > http://www.science.uva.nl/research/air/wiki/LinkLocalARPMeasurements
 > 
 > To the linux kernel to get proper zcip behavior.
 > 
 > 
 > David Daney
 > 
 > --------------020300070009060903050206
 > Content-Type: text/x-patch;
 >  name="zcip.patch"
 > Content-Transfer-Encoding: 7bit
 > Content-Disposition: inline;
 >  filename="zcip.patch"
 > 
 > --- networking/zcip.c.orig	2006-03-29 14:01:56.000000000 -0800
 > +++ networking/zcip.c	2006-03-29 14:02:20.000000000 -0800
 > @@ -437,7 +437,7 @@
 >  
 >  				gettimeofday(&tv2, NULL);
 >  				if (timercmp(&tv1, &tv2, <)) {
 > -					timeout = -1;
 > +					timeout = 0;
 >  				} else {
 >  					timersub(&tv1, &tv2, &tv1);
 >  					timeout = 1000 * tv1.tv_sec
 > 
 > --------------020300070009060903050206
 > Content-Type: text/plain; charset="us-ascii"
 > MIME-Version: 1.0
 > Content-Transfer-Encoding: 7bit
 > Content-Disposition: inline
 > 
 > _______________________________________________
 > busybox mailing list
 > busybox at busybox.net
 > http://busybox.net/cgi-bin/mailman/listinfo/busybox
 > --------------020300070009060903050206--

=---------------------
 paul fox, pgf at brightstareng.com


More information about the busybox mailing list