[PATCH] remove hardcoded selection for HEX ESCAPES(???)
Robert P. J. Day
rpjday at mindspring.com
Wed Mar 29 08:45:49 PST 2006
On Wed, 29 Mar 2006, Rich Felker wrote:
> On Wed, Mar 29, 2006 at 11:26:09AM -0500, Robert P. J. Day wrote:
> >
> > (if this patch is appropriate, feel free to apply it. it
> > removes the hardcoded setting of the macro WANT_HEX_ESCAPES plus
> > the subsequent conditionals based on it. it's not clear whether
> > it makes much sense to have that kind of conditional proprocessing
> > if it's not a menu configuration selection. it's also not clear
> > why you *wouldn't* want hex escapes but if there's a good reason
> > to keep supporting that, then feel free to toss this patch.)
>
> What programs use this file?
a quick recursive grep shows:
coreutils/tr.c
coreutils/printf.c
e2fsprogs/fsck.c
editors/awk.c
libbb/bb_echo.c
loginutils/getty.c
shell/cmdedit.c
shell/lash.c
> I expect these hex escapes are a GNU extension that's incompatible
> with SUSv3, in which case it would be nice to be able to disable
> them along with other GNU extensions.
no argument there. notice i *didn't* say that this conditional had no
value. what i said was that it has little value if it's implemented
by hardcoding it in the source file. if it really deserves to be a
choice, then its selection should be moved to the config menu, that's
all.
perhaps this feature should be made part of a larger class of
"non-SUSv3" thingies. or however that would work.
rday
More information about the busybox
mailing list