[PATCH] Remove extraneous cruft from end of libbb/Makefile.in

[Bernhard Fischer]

On Tue, Mar 28, 2006 at 03:34:45AM -0500, Robert P. J. Day wrote:
>
>  [NOTE:  This stuff at the end of libbb/Makefile.in doesn't
>**appear** to have any value but I've been wrong before.]

These are needed for CONFIG_BUILD_AT_ONCE.
>
>  [NOTE 2:  I just realized this won't apply cleanly if my earlier
>patch is applied first but that would be easy to fix.]

I fail to see the benefit of your previous patch to add vpath.
Doesn't this just make the build (slightly) slower since you removed the
explicit path to the source? It sounds like with your proposed patch,
make would have to iterate over a list (of several vpath's) instead of
the explicit path..

Can you show us a diff between
make clean ; (make -d -p) 2>&1 >&1 | tee OUT.orig
and the same with your "earlier" patch applied?


>
>
>diff -pru busybox.orig/libbb/Makefile.in busybox/libbb/Makefile.in
>--- busybox.orig/libbb/Makefile.in	2006-03-28 03:14:45.000000000 -0500
>+++ busybox/libbb/Makefile.in	2006-03-28 03:30:11.000000000 -0500
>@@ -135,14 +135,5 @@ LIBBB_OBJS:=$(patsubst $(srcdir)/%.c,$(L
> $(LIBBB_DIR)/%.o: $(srcdir)/%.c
> 	$(compile.c)
>
>-LIBBB_SRC-a:=$(wildcard $(srcdir)/*.c)
>-LIBRARY_SRC-y+=$(LIBBB-y)
>-LIBRARY_SRC-a+=$(LIBBB_SRC-a)
>-
>-# all defines needed for 1:N objects
>-LIBBB_DEFINE-y:=$(patsubst %,-DL_%,$(subst .o,,$(notdir $(LIBBB_ALL_MOBJ))))
>-LIBRARY_DEFINE-y+=$(LIBBB_DEFINE-y)
>-LIBRARY_DEFINE-a+=$(LIBBB_DEFINE-y)
>-
> $(LIBBB_AR): $(LIBBB_OBJS) $(LIBBB_ALL_MOBJ)
> 	$(do_ar)
>
>Signed off by:  Robert P. J. Day <rpjday at mindspring.com>
>_______________________________________________
>busybox mailing list
>busybox at busybox.net
>http://busybox.net/cgi-bin/mailman/listinfo/busybox
>