[PATCH] accept different libselinux installation path

Jan Kiszka jan.kiszka at web.de
Tue Mar 28 00:20:16 PST 2006


Jan Kiszka wrote:
> Mike Frysinger wrote:
>> On Monday 27 March 2006 11:57, Jan Kiszka wrote:
>>> in case the libselinux development installation is not located at its
>>> default location, this patch allows to override the path via SELINUX_INC
>>> and SELINUX_LIB when invoking make. Feel free to suggest a cleaner
>>> variant, this was just trimmed to work.
>> defaulting includes to such system paths makes no sense
>>
>> what's wrong with forcing users to run:
>> CFLAGS=-I/usr/some/funky/path/to/selinux \
>> LDFLAGS=-L/usr/some/funky/path/to/selinux \
>> make
>> -mike
> 
> As I said: you are welcome to correct me :). I think to remember that
> this once doesn't work, but now as you ask I may confuse this with a
> less cleanly organised build system of a different project. I will check
> this and may post a reversion patch for the path settings.
> 

Yep, you are right, works fine as you suggested. Attached is a partial
reversion of my patch.

Jan
-------------- next part --------------
Index: Rules.mak
===================================================================
--- Rules.mak	(revision 14678)
+++ Rules.mak	(working copy)
@@ -210,11 +210,7 @@ endif
 
 
 ifeq ($(strip $(CONFIG_SELINUX)),y)
-    SELINUX_INC ?= /usr/include
-    SELINUX_LIB ?= /usr/lib
-    CFLAGS      := -I$(SELINUX_INC) $(CFLAGS)
-    LDFLAGS     := -L$(SELINUX_LIB) $(LDFLAGS)
-    LIBRARIES   += -lselinux
+    LIBRARIES += -lselinux
 endif
 
 ifeq ($(strip $(PREFIX)),)


More information about the busybox mailing list