[PATCH] combine libbb/xgethostbyname*.c source files into one

Robert P. J. Day rpjday at mindspring.com
Mon Mar 27 07:53:07 PST 2006


On Mon, 27 Mar 2006, Jason Schoon wrote:

> On 3/27/06, Robert P. J. Day <rpjday at mindspring.com> wrote:
> >
> >   (analogous to combining the create_icmp*_socket.c source files,
> > there seems to be little reason to have two separate source files for
> > these two functions.  i'm still not sure what variation of "diff" to
> > run to reflect deleted files -- is this the correct diff output?)
> >
> The reason for having 2 different files is so if you are only using
> one of the two functions based on your configuration, the linker
> will not need to include the other object at all.  In this case, not
> including IPV6 allows the xgethostbyname2 object to not be linked.
> Libbb seems extremely segmented and far too many files to me, but I
> believe this is the reason it was created in that fashion.

yes, i realized that after i give it a few seconds thought.  in any
event, the contents of libbb are still somewhat inconsistent since a
number of the files do have multiple object file production
capability, while others seem to be obvious candidates for exactly the
same thing.  just making the observation.

rday


More information about the busybox mailing list