[PATCH RESEND] size reduction and coding style for who.c

Rob Landley rob at landley.net
Sat Mar 11 10:24:34 PST 2006


On Saturday 11 March 2006 9:53 am, Tito wrote:
> Hi,
> the first patch reduces size of who.c and cleans up the code.
> Size reduction is:
>
>   text    data     bss     dec     hex filename
>     588       0       0     588     24c who.o.orig
>     521       0       0     521     209 who.o

Very nice.  Applied.

> The second patch fixes the coding style with no changes to the binary.

Changing spaces to tabs is cool.  Why the extra curly brackets around single 
line ifs?  (I haven't rejected this one, I'm just asking if there's a 
rationale here.  Seems an aesthetic choice.)

Rob
-- 
Never bet against the cheap plastic solution.


More information about the busybox mailing list