[PATCH] aesthetic endian-related patch

Rob Landley rob at landley.net
Mon Mar 6 14:43:10 PST 2006


On Saturday 04 March 2006 11:26 am, Robert P. J. Day wrote:
>   a first attempt.

> -#else
> -#define __swap16(x) (x)
> -#define __swap32(x) (x)
> -#endif
> +#else /* it's little-endian */
> +# define __swap16(x) (x)
> +# define __swap32(x) (x)
> +#endif /* BB_BIG_ENDIAN */

I dislike indenting preprocessor macros.  If the topic comes up, it generally 
means there are too many preprocessor macros, and putting the space after the 
# instead of before it disturbs me because I mentally consider #ifdef to be a 
token.

But I realize there are others who disagree with me on this aesthetic...

However, switching over to the BB_ macros for endianness is something we need 
to do anyway, so...

Applied.

Rob

(Why is this sitting around on my desktop rather than sent already?)
-- 
Never bet against the cheap plastic solution.


More information about the busybox mailing list