TODO: RESERVE_CONFIG_BUFFER [was: Re: Pending patches status?]

[Bernhard Fischer]

On Thu, Mar 02, 2006 at 02:53:59PM -0500, Rob Landley wrote:
>On Thursday 02 March 2006 2:18 am, Denis Vlasenko wrote:

>                                                  I'm taking a whack at the 
>tar thing in a slightly different way (using bb_common_bufsiz1 and memset to 
>create a large write inline, need to test it before checking it in...)
>
>The others I'd like to get back to on monday.

I want to
ifneq ($(EXTRAVERSION),)
$(call check_gcc,CFLAGS,-Wlarger-than-63,)
endif

For anything which is not an actual release, warn about anything which
is larger than 63 Bytes ¹) to _encourage_ the use of
RESERVE_CONFIG_BUFFER and friends.

Objections wrt
1) warning more verbosely for _any_ non-release?
2) RESERVE_CONFIG_BUFFER et al?

I'm well aware that when we add this the first time, there will be
relatively much noise. Still it is fine to clean them up in the
mid-term. Keep in mind that this is exactly one of the areas, where we
loose alot of ground, size wise.
This and duplicate code (peruse llist in sed etc!!) are the biggest
offendors overall which don't take much effort to straighten out ²).

¹) -Wlarger-than-len
Warn whenever an object of larger than len bytes is defined.

²) base64 encoding comes to mind. Same for potential llist users, as
said. etc, etc.

cheerio,
Bernhard