svn commit: trunk/busybox/libbb

[Peter S. Mazinger]

On Wed, 21 Jun 2006, Rob Landley wrote:

> P.S.  Ok, It seems I can't leave it alone.  I just looked up asm/termbits.h on 
> my Red Hat 9 qemu image and lo and behold, it has all the #defines up to 
> B4000000.  And that says to _me_ that we can use those without an #ifdef 

Please do the same for all libc/sysdeps/linux/*bits/termios.h on 
uClibc-svn as well, there you will see differences (the generic file is 
for example limited to 115200 and any arch needing more, like cris has 
its own file). The code in busybox seems to be copied from 
libc/termios/cfsetspeed.c, Couldn't cfset{,i,o}speed() be used in busybox?

Peter

> (since that's the oldest Linux build environment we still support).  
> Non-linux platforms that want to use this code should probably put #defines 
> for these values in platform.h, which is where this kind of ugliness belongs.  
> Not in the applets themselves.
> 
> Right, with the #ifdefs dealt with that just leaves the size, which isn't 
> _that_ bad and I'll deal with it on thursday.
> 
> I'm going to bed now.
> 
> Still Rob
> 

-- 
Peter S. Mazinger <ps dot m at gmx dot net>           ID: 0xA5F059F2
Key fingerprint = 92A4 31E1 56BC 3D5A 2D08  BB6E C389 975E A5F0 59F2