[patch] various bugs and strncpy abuse followup

Rob Landley rob at landley.net
Thu Jun 8 07:20:21 PDT 2006


On Thursday 08 June 2006 2:15 am, Tito wrote:
> Please apply the last part of the patch as it fixes a real bug:
>
> @@ -1311,9 +1313,9 @@
>         /* compare_string_array returns i>=0  */
>         i=compare_string_array(field_names, variable);
>
> -       if ( i > 6 && (i > 1 && gv_info == NULL))
> -                       return (NULL);
> -       if( i >= 0 || i <= 3)
> +       if (i > 6 || (i > 1 && gv_info == NULL) || i < 0)
> +               return (NULL);
> +       if( i <= 3  && i >= 0 )

Applied.

Rob
-- 
Never bet against the cheap plastic solution.


More information about the busybox mailing list