[PATCH] ed stuff #1

[Bernhard Fischer]

On Tue, Jun 06, 2006 at 05:18:50PM -0400, Rob Landley wrote:
>On Thursday 01 June 2006 3:39 pm, Bernhard Fischer wrote:
>> Hi,
>>
>> ed is a) bloated and b) broken.
>> The attached patchlet starts to look a tiny bit into a)
>>
>> Comments? Ok to checkin?
>>
>>    text    data     bss     dec     hex filename
>>  864338   10244  645924 1520506  17337a busybox_old
>>  864114   10244  645924 1520282  17329a busybox_unstripped
>>
>> thanks,
>
>I have no attachment whatsoever to ed, but I do care about libbb.  You're 
>adding a new function and attributing it to Manuel Nova from three years ago?

That attribution is not strictly correct, agree..
>
>Why have both skip_whitespace() and skip_blank()?  What's the point?  I notice 
>that ed.c uses isblank() for everything, and never isspace(), so it's not 
>actually _distinguishing_ between them.  That seems more like a stylistic 
>choice than anything else.

Well i don't know ed too well and thought that since blank != space it
would be safer to keep it like it was. Perhaps someone more familiar
with ed can shed some light?
>
>If you really do feel the need to add skip_blank(), just throw it in 
>skip_whitespace.c (since you're touching that file anyway...) and make it a 
>mult-obj file.  But better yet, can ed.c just use skip_whitespace?

As said, space is not the same as blank, so i'm really not sure if ed
could use skip_whitespace or not.