[PATCH] Include netinet/in.h in libbb.h

[Rob Landley]

On Saturday 03 June 2006 3:18 pm, Bernhard Fischer wrote:
> On Sat, Jun 03, 2006 at 12:25:36PM -0600, Shaun Jackman wrote:
> >On 7/25/05, Rob Landley <rob at landley.net> wrote:
> >...
> >
> >>But applied anyway...
> >>
> >>Rob
> >
> >This patch was never applied; please apply it now.
> >
> >libbb.h uses struct sockaddr_in which is defined in netinet/in.h but
> >never included.
>
> This patch shouldn't be needed anymore since the order of includes were
> restructered recently. Applets have to include busybox.h as the first
> include, lib*/* has to include libbb.h as the first include.
>
> Applets and library functions MUST not include any header which is
> included by platform.h, busybox.h and platform.h, libbb.h respectively.

"Must" is a bit strong.  Shouldn't.

In general, it would be nice if applets could just #include one header file 
and all the weird issues that keep coming up about which header files apply 
to which platforms and what order they have to go in in order to avoid 
stomping each other (yes, the recent Red Hat build break) were just not an 
applet's problem.

Rob
-- 
Never bet against the cheap plastic solution.