[PATCH] Integrate dd ibs/obs patch

Paul Fox pgf at brightstareng.com
Thu Jun 1 05:43:23 PDT 2006


 > >  > Hmmm...  If somebody specifies both obs= and bs= they can cause the size
 > >  > to be something that the !twobufs_flag codepath doesn't expect.  I'll
 > >  > fix it.  (And the #ifdefs are going away; The !twobufs_flag codepath
 > >  > should be the same whether the twobufs part is enabled or not.)
 > >  >
 > >  > conv= should be under this config flag as well.
 > >
 > > i don't understand the last part of this change.
 > >
 > > why are the "notrunc" and "noerror" conv options conditional on
 > > the FEATURE_DD_IBS_OBS?
 > 
 > Basically using it as a DD_BIG switch?

oh.  i see.  yes, in that case it should be "CONFIG_FANCY_DD", or
something like that.

 > 
 > > i can separate them, if it's the right thing -- i have another
 > > conv= option i'd like to add, and it's definitely independent of
 > > ibs/obs, so i need to clean this up for my own use in any case.
 > 
 > I'm not _against_ adding configuration granularity, but it seems like it's 
 > about time to add a CONFIG_NITPICK switch.
 > 
 > I just did so.

huh?  is that an ifdef we can apply to mailing list text?  ;-)

paul
=---------------------
 paul fox, pgf at brightstareng.com


More information about the busybox mailing list