bb tar (1.1.3) bug?

[Glenn L McGrath]

On Tue, 18 Jul 2006 10:28:21 -0400 (EDT)
"Robert P. J. Day" <rpjday at mindspring.com> wrote:

> On Tue, 18 Jul 2006, Cristian Ionescu-Idbohrn wrote:
> 
> ... snip ...
> 
> > Index: find_list_entry.c
> > ===================================================================
> > RCS file: /cvs/busybox/archival/libunarchive/find_list_entry.c,v
> > retrieving revision 1.1.1.2
> > retrieving revision 1.4
> > diff -u -b -B -p -r1.1.1.2 -r1.4
> > --- find_list_entry.c	29 Jun 2006 16:18:07 -0000
> > 1.1.1.2 +++ find_list_entry.c	18 Jul 2006 09:17:13
> > -0000	1.4 @@ -21,7 +21,7 @@
> >  const llist_t *find_list_entry(const llist_t *list, const char
> > *filename) {
> >  	while (list) {
> > -		if (fnmatch(list->data, filename, 0) == 0) {
> > +		if (fnmatch(list->data, filename, FNM_LEADING_DIR)
> > == 0) { return(list);
> >  		}
> >  		list = list->link;
> > ---8<---
> 
> there have been at least a couple threads on precisely this topic, one
> starting here:
> 
>   http://www.busybox.net/lists/busybox/2006-April/020461.html
> 
> the primary objection to that fix is expressed by rich felker here:
> 
>   http://www.busybox.net/lists/busybox/2006-April/020578.html
> 
> so, at this point, i guess it's still an open problem.

I think we are trying to do too much with one function, in some places
we want to match subdirectories and some places we dont, so we really
need two search routines.


Glenn