[PATCH] sulogin size reduction and clean up

[Rob Landley]

On Monday 17 July 2006 9:38 am, Tito wrote:
> On Monday 17 July 2006 00:17, Rob Landley wrote:
> > On Saturday 15 July 2006 4:25 pm, Tito wrote:
> > > Hi,
> > > this patch reduces the size of sulogin and cleans up the code.
> > > The patch also adds a config option to enable/disable syslogging in
> > > sulogin.
> >
> > If you'd like a global switch to enable/disable syslog support in
> > applets, that's one thing.  But adding an "And should THIS applet do
> > syslog?  Or how about THIS one?  What about THIS one?" to each applet's
> > config?  Not so much. (At the very least: CONFIG_NITPICK.)
>
> Hi,
> I thought to add one general switch for loginutils (default on?), but only
> after all applets were ported to this feature, but if you like it we can do
> it the other way first create the global switch and then modify the single
> applets
>
> Let me know your opinion.

You mean syslog?  I prefer adding the one general switch and then porting the 
applets to use it.

Also, any thoughts on some kind of libbb do_syslog() wrapper function that 
does it all in one go?  (Is there a lot of overhead for openlog() and 
closelog()?  Is an applet not supposed to do it more than once...?)

Rob
-- 
Never bet against the cheap plastic solution.