strangeness involving e2fsprogs header files

[Rob Landley]

On Monday 03 July 2006 9:05 am, Robert P. J. Day wrote:
> On Mon, 3 Jul 2006, Mike Frysinger wrote:
> > On Monday 03 July 2006 07:53, Robert P. J. Day wrote:
> > >   in my travels through the source code, i wandered across the
> > > fact that a number of header file inclusions under e2fsprogs use
> > > relative pathnames:
> > >
> > >   e2fsprogs/e2p/uuid.c:#include "../ext2fs/ext2_types.h"
> > >   e2fsprogs/e2p/e2p.h:#include "../ext2fs/ext2_fs.h"
> > >   e2fsprogs/blkid/read.c:#include "../uuid/uuid.h"
> > >   e2fsprogs/ext2fs/mkjournal.c:#include "../e2p/e2p.h"
> > >   e2fsprogs/ext2fs/mkjournal.c:#include "../e2fsck.h"
> >
> > this was done on purpose ... since the build system tends to be on
> > the fragile side, using paths such as these:
>
> not to belabour this point, but it would seem to me that hard-coding
> filenames which might break if anything is moved around is actually
> more "fragile" than just defining the appropriate preprocessor
> directives to handle this situation in general, no?

Yes.  This directory is CRAP, it was only put in on the assumption somebody 
would clean it up, and I've been on the verge of removing it for a while.

> rday

Rob
-- 
Never bet against the cheap plastic solution.