svn commit: trunk/busybox/networking

[Bernhard Fischer]

On Sat, Jul 01, 2006 at 08:00:01AM -0700, rpjday at busybox.net wrote:
>Author: rpjday
>Date: 2006-07-01 07:59:54 -0700 (Sat, 01 Jul 2006)
>New Revision: 15572

>Modified: trunk/busybox/networking/ifupdown.c
>===================================================================
>--- trunk/busybox/networking/ifupdown.c	2006-07-01 14:52:12 UTC (rev 15571)
>+++ trunk/busybox/networking/ifupdown.c	2006-07-01 14:59:54 UTC (rev 15572)
>@@ -43,11 +43,7 @@
> #define MAX_INTERFACE_LENGTH 10
> #endif
> 
>-#if 0
>-#define debug_noise(fmt, args...) printf(fmt, ## args)
>-#else
> #define debug_noise(fmt, args...)
>-#endif
> 
> /* Forward declaration */
> struct interface_defn_t;

Whoever that may be..
Doing stuff like this is nonsense, to say the least.

You're breaking the conventient possibility to turn on debugging
facilities with what reasoning again?

Either do it right (export the debug_noise into config / remove all
debugging support completely; Exporting it is pointless, imo and
removing it is of questionable use anyway since it's easier to tell
people to toggle that single #if 0 to see why they fail than to delve
into a blind indirect debugging session in order to help them) or just
leave it alone.