ifupdown open for no purpose

Denis Vlasenko vda at ilport.com.ua
Mon Feb 27 10:28:44 UTC 2006


A nitpick:

extern int ifupdown_main(int argc, char **argv)
{
        int (*cmds) (struct interface_defn_t *) = NULL;
        struct interfaces_file_t *defn;
        llist_t *state_list = NULL;
        llist_t *target_list = NULL;
        const char *interfaces = "/etc/network/interfaces";
        const char *statefile = "/var/run/ifstate";
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Maybe static const char statefile[] = "/var/run/ifstate"; ?
You never modify the pointer.
--
vda



More information about the busybox mailing list