ifupdown open for no purpose

Rob Landley rob at landley.net
Sun Feb 26 04:42:55 UTC 2006


On Saturday 25 February 2006 7:25 pm, Glenn L. McGrath wrote:
> On Sun, 26 Feb 2006 12:54:29 +1300
>
> "Glenn L. McGrath" <bug1 at ihug.co.nz> wrote:
> > When in no action mode ifupdown was opening the state file for
> > apparently no reason at all.
> >
> > It didnt no anything with it, bypasses the error checking code... it
> > looks like it was there from the begining.
>
> The attahced patch also cleans up writing to the state file, any reason
> why it would be opening in a+ and then truncating to 0 ?

It seems like your new one doesn't seem to truncate the existing file, so if 
you write a shorter amount of data it could have trailing crap.  Did I 
misread?

Also, this patch doesn't apply on top of the previous one.

> Glenn

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list