svn commit: trunk/busybox: archival coreutils miscutils modutils ne etc...

[Mike Frysinger]

On Sunday 31 December 2006 01:56, Rich Felker wrote:
> On Sat, Dec 30, 2006 at 08:57:10PM -0500, Mike Frysinger wrote:
> > On Saturday 30 December 2006 17:26, Yann E. MORIN wrote:
> > > --- busybox.org/coreutils/od_bloaty.c   (revision 17105)
> > > +++ busybox.org/coreutils/od_bloaty.c   (working copy)
> > > @@ -1437,7 +1437,7 @@
> > >                         bytes_per_block > > >                 if (!bytes_per_block || bytes_per_block % l_c_m !> > >                         bb_error_msg("warning: invalid width %u; using
> > > %d instead", -                                       bytes_per_block,
> > > l_c_m); +                                       (unsigned int)
> > > bytes_per_block, l_c_m); bytes_per_block > > >                 }
> > >         } else {
> >
> > ugh, please dont cast ... are people against using '%zu' ?
>
> I'm not against it, but maybe some broken libc implementations (diet,
> anyone? :) lack %zu. Casting to long and using %lu would be safe on
> any reasonable system (Win64 is not reasonable..).

the spec requires z to be supported so if your libc is crappy and doesnt, well 
that sucks ...

throwing in casting everywhere just leads to trouble
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20061231/7cd2a294/attachment.pgp