svn commit: trunk/busybox: archival coreutils miscutils modutils ne etc...
Rich Felker
dalias at aerifal.cx
Sat Dec 30 22:56:44 PST 2006
On Sat, Dec 30, 2006 at 08:57:10PM -0500, Mike Frysinger wrote:
> On Saturday 30 December 2006 17:26, Yann E. MORIN wrote:
> > --- busybox.org/coreutils/od_bloaty.c (revision 17105)
> > +++ busybox.org/coreutils/od_bloaty.c (working copy)
> > @@ -1437,7 +1437,7 @@
> > bytes_per_block = xatou(str_w);
> > if (!bytes_per_block || bytes_per_block % l_c_m != 0) {
> > bb_error_msg("warning: invalid width %u; using %d
> > instead", - bytes_per_block, l_c_m);
> > + (unsigned int) bytes_per_block,
> > l_c_m); bytes_per_block = l_c_m;
> > }
> > } else {
>
> ugh, please dont cast ... are people against using '%zu' ?
> -mike
I'm not against it, but maybe some broken libc implementations (diet,
anyone? :) lack %zu. Casting to long and using %lu would be safe on
any reasonable system (Win64 is not reasonable..).
Rich
More information about the busybox
mailing list