svn commit: trunk/busybox/networking/udhcp

Bernhard Fischer rep.nop at aon.at
Fri Dec 22 03:55:05 PST 2006


On Fri, Dec 22, 2006 at 03:47:19AM -0800, vda at busybox.net wrote:
>Author: vda
>Date: 2006-12-22 03:47:19 -0800 (Fri, 22 Dec 2006)
>New Revision: 17047
>
>Log:
>Always use /usr/share/udhcpc/default.script ([/usr] was depending on CONFIG_xx)
>
>
>Modified:
>   trunk/busybox/networking/udhcp/common.h
>
>
>Changeset:
>Modified: trunk/busybox/networking/udhcp/common.h
>===================================================================
>--- trunk/busybox/networking/udhcp/common.h	2006-12-22 11:45:20 UTC (rev 17046)
>+++ trunk/busybox/networking/udhcp/common.h	2006-12-22 11:47:19 UTC (rev 17047)
>@@ -12,11 +12,7 @@
> 
> #include "busybox.h"
> 
>-#ifdef CONFIG_INSTALL_NO_USR
>-# define DEFAULT_SCRIPT  "/share/udhcpc/default.script"
>-#else
>-# define DEFAULT_SCRIPT  "/usr/share/udhcpc/default.script"
>-#endif
>+#define DEFAULT_SCRIPT  "/usr/share/udhcpc/default.script"

You force anybody to create three superfluous directories. Why?

Mind if i change that to
#ifdef CONFIG_INSTALL_NO_USR
# define DEFAULT_SCRIPT  "/etc/dhclient-script"
#else
#define DEFAULT_SCRIPT  "/usr/share/udhcpc/default.script"
#endif

$  dpkg -S /etc/dhclient-script
dhcp-client: /etc/dhclient-script

What do you think?
thanks,


More information about the busybox mailing list