[PATCH] add a few new xfuns and use them as appropriate

Bernhard Fischer rep.nop at aon.at
Wed Apr 12 12:06:21 UTC 2006


On Wed, Apr 12, 2006 at 12:41:52PM +0300, Denis Vlasenko wrote:
>On Wednesday 12 April 2006 11:45, Bernhard Fischer wrote:
>> On Mon, Mar 13, 2006 at 08:56:22AM +0200, Denis Vlasenko wrote:
>> >Hi,
>> >
>> >We have a lot of this:
>> >
>> >if (stat(old_path, &stat_buf) < 0)
>> >    bb_error_msg_and_die("Couldn't stat file %s", old_path);
>> >
>> >xstat() would make it smaller. These patches do that.
>> >
>> >Patches are posted as replies. Please apply.
>> 
>> I'd like to apply your stat?.patch, and would also be interrested in the
>> bb_xopen3.patch (with sizes after the applets are converted).
>> 
>> Could you please respin the stat?.patches and convert them to have a bb_
>> prefix and put them somewhere with sizes?
>
>Rediffed patches are attached.

Cool, thanks.

I saw that you didn't add a license to the new files in libbb.
Can we put them under LGPLv2.1 or later?

I will add http://www.gnu.org/copyleft/lesser.txt as docs/lesser.txt as
several parts of lib*/ are under LGPLv2.1 or later.

PS:
The stat4 patch seems to add to the size a bit with gcc >= 4.1 in contrast
to the other patches so i'm hesitating to apply it for now..

   text    data     bss     dec     hex filename
 889305    9392 1035784 1934481  1d8491 busybox.orig.gcc-4.2-HEAD
 888977    9392 1035784 1934153  1d8349 busybox.stat2.gcc-4.2-HEAD
 888865    9392 1035784 1934041  1d82d9 busybox.stat3.gcc-4.2-HEAD
 888889    9392 1035784 1934065  1d82f1 busybox.stat4.gcc-4.2-HEAD
 888661    9392 1035784 1933837  1d820d busybox.stat5.gcc-4.2-HEAD
 888817    9820 1037860 1936497  1d8c71 busybox.orig.gcc-4.1-HEAD
 888449    9820 1037860 1936129  1d8b01 busybox.stat2.gcc-4.1-HEAD
 888353    9820 1037860 1936033  1d8aa1 busybox.stat3.gcc-4.1-HEAD
 888449    9820 1037860 1936129  1d8b01 busybox.stat4.gcc-4.1-HEAD
 888321    9820 1037860 1936001  1d8a81 busybox.stat5.gcc-4.1-HEAD
 904709   10768 1038276 1953753  1dcfd9 busybox.orig.gcc-4.0
 904341   10768 1038276 1953385  1dce69 busybox.stat2.gcc-4.0
 904229   10768 1038276 1953273  1dcdf9 busybox.stat3.gcc-4.0
 904229   10768 1038276 1953273  1dcdf9 busybox.stat4.gcc-4.0
 904165   10768 1038276 1953209  1dcdb9 busybox.stat5.gcc-4.0
 896119   10740 1038020 1944879  1dad2f busybox.orig.gcc-3.4
 895751   10740 1038020 1944511  1dabbf busybox.stat2.gcc-3.4
 895671   10740 1038020 1944431  1dab6f busybox.stat3.gcc-3.4
 895607   10740 1038020 1944367  1dab2f busybox.stat4.gcc-3.4
 895287   10740 1038020 1944047  1da9ef busybox.stat5.gcc-3.4
 942270   10700 1038084 1991054  1e618e busybox.stat2.gcc-3.3
 942174   10700 1038084 1990958  1e612e busybox.stat3.gcc-3.3
 942174   10700 1038084 1990958  1e612e busybox.stat4.gcc-3.3
 941966   10700 1038084 1990750  1e605e busybox.stat5.gcc-3.3




More information about the busybox mailing list