busybox.h vs libbb.h

Bernhard Fischer rep.nop at aon.at
Sun Apr 2 21:12:34 UTC 2006


On Sun, Apr 02, 2006 at 02:13:49PM -0500, Rob Landley wrote:
>On Sunday 02 April 2006 6:43 am, Bernhard Fischer wrote:
>> >> can we pick one ?  it'd be trivial to update the build tests to check
>> >> for this -mike
>> >
>> >You mean merge them?
>> >
>> >I suppose so.  I vaguely remember looking at it and one point and there
>> > was a reason they were separate, but I don't remember it being an
>> > insurmountable reason.  You're welcome to try.  The logical one to keep
>> > would be busybox.h...
>>
>> I'm not opposed to merging them, but we are not going to need the
>> struct BB_applet and the applet prototypes when we will install
>> a header for use with the library.
>> So if these are invisible outside of -DBUILDING_BUSYBOX_C, then
>> everything is fine.
>
>Sounds like an argument for keeping them separate to me...

It would IMO be cleaner to have them separate but if folks have a strong
need to merge them, I could bend it to behave..

That said, we could shift the applet prototypes to an applets.h and mv
the current applets.h to applet_list.h (or the like), but thats just
moving stuff around for no real benefit, imho.

Mike, is there a specific reason why you would want to merge busybox.h
and libbb.h apart from just sloppily including busybox.h anywhere
instead of knowing what one needs where?



More information about the busybox mailing list