[PATCH] dont compile pwd_to_spwd when shadow passwds is off

[Amir Shalem]

On Sat, Sep 17, 2005 at 02:08:33PM -0500, Rob Landley wrote:
>On Saturday 17 September 2005 02:20, Amir Shalem wrote:
>> >Are you saying that enabling CONFIG_USE_BB_SHADOW still requires shadow
>> >password support in uClibc in order to compile?  If so, what's the point
>> > of that option even existing?
>>
>> no,
>> i'm saying that enabling CONFIG_USE_BB_SHADOW
>> still requires you to have pwd2spwd.c
>
>But can you compile it in any environment where it would be useful?

yes, it pwd2spwd will both with CONFIG_USE_BB_SHADOW and system shadow.

>
>> pwd2spwd should be enabled only if CONFIG_FEATURE_SHADOWPASSWDS is on.
>>
>> CONFIG_USE_BB_SHADOW lets you have shadow support within busybox programs
>> su, login, passwd, etc, without having shadow support in uclibc.
>
>If you have CONFIG_USE_BB_SHADOW, and build against a uclibc that does not 
>have shadow support (and thus does not have shadow.h), will it compile?

yes,
all shadow users in busybox do NOT include <shadow.h>
they include "shadow_.h" which decides whether to use system shadow
or busybox shadow functions according to CONFIG_USE_BB_SHADOW value.

>Are you saying that the only way to use CONFIG_USE_BB_SHADOW is to build 
>against a uclibc that includes shadow support?  If so, what is the purpose of 
>CONFIG_USE_BB_SHADOW?  This code only compiles when it's redundant?

compiling with CONFIG_USE_BB_SHADOW against uclibc with shadow support
is redundant, and may cause conflicts, as the libc and busybox will contain
duplicate function symbols (setspent, getspent, ...)

CONFIG_USE_BB_SHADOW should be used when libc does not have shadow support
and user needs shadow support CONFIG_FEATURE_SHADOWPASSWDS

>That's the point I'm trying to clarify.

ok,
but this point relation to the bug i'm refering to
is that because i have no CONFIG_USE_BB_SHADOW, nor shadow support in libc
pwd2spwd fails to compile, but pwd2spwd is not required for me,
because I have CONFIG_FEATURE_SHADOWPASSWDS off,
so all shadow users code in busybox should be disabled,
and this includes pwd2spwd.c

-- 
	Amir.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20050918/ea3db0cf/attachment-0002.pgp