[BusyBox] tail: dprintf [PATCH]
Rob Landley
rob at landley.net
Sat May 7 16:46:05 UTC 2005
On Saturday 07 May 2005 12:08 pm, Manuel Novoa III wrote:
> > You're right, dprintf(STDOUT_FILENO,...) is a pointless obfuscation of a
> > normal printf.
>
> Except that dprintf doesn't go through stdio buffering and you've
> replaced one 3-arg function call with a 2-arg function call, a 1 arg
> function call, and an additional conditional.
>
> What was the change in the generated code size?
>
> Manuel
Sigh. Went through the patch backlong, found a nice small patch that seemed
to do something obvious and that nobody objected to for a month, And you're
right, I forgot about the added flush. The second function call would indeed
make it bigger...
Reverted.
Rob
More information about the busybox
mailing list