[BusyBox] Re: ifconfig: Clean up. [PATCH]
Rob Landley
rob at landley.net
Tue Jul 26 10:12:21 UTC 2005
On Tuesday 26 July 2005 01:55, Shaun Jackman wrote:
> On 7/25/05, Rob Landley <rob at landley.net> wrote:
> > > I'd to spell do_cleanup as DO_CLEANUP. If I saw...
> > > if (DO_CLEANUP)
> > > ... I'd understand it was a conditional compilation. If I saw...
> > > if (do_cleanup)
> >
> > I was actually thinking of a static const int.
>
> Getting back to the original thread of conversation, here's an
> implementation of my previous idea. I rather like the consistency this
> method offers.
If we're going to do this (and I suppose the fact that CONFIG_FEATURE_CLEAN_UP
is a symbol we're already familiar with outweights the fact it's a bit
verbose and loud), then we really should have the build process generate
these programmatically. I.E. add the following to the config.h generator in
the build file:
sed -e 's/#undef CONFIG_\(.*\)/#define CONFIG_\1 0/' -i config.h
Note that this misses "USING_CROSS_COMPILER", and that I personally don't
care.
Rob
More information about the busybox
mailing list