[BusyBox] PATCH - DHCP Addtional Items - X3

[duane no-name]

>> I'd like to see standardized formatting, ie,
if(require_option(optarg)) {, instead of if(
require_option(optarg) ){. 

Fixed - missed last time I fixed the 'standardized
formatting' I can't seem to find or see any more nits
like this.

>> Also, I'm not sure if you want udhcpc tobomb if an
option isn't found, just print a log message and
continue, since different versions might support
different options, and not having an option is not
necessarily fatal. 

Fixed, now fprintf() to stderr with WARNING and
continue.

Note: Can't really send it to a log - because the log
file is not open at the time of cmdline parsing, hence
the use of fprintf( stderr, "WARNING...");

>> And, don't forget to update the help in busybox, as
well as the man page.

The appropriate README file was already updated in the
patch. 

I was unaware of the 'usage.h' - it was not obvious, I
would have expected this sort of stuff to be extracted
from the module directory - not off some where else.



__________________________________
Do you Yahoo!?
Get better spam protection with Yahoo! Mail.
http://antispam.yahoo.com/tools
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-1.00-pre7-dhcp-patch-3
Type: application/octet-stream
Size: 4608 bytes
Desc: busybox-1.00-pre7-dhcp-patch-3
Url : http://lists.busybox.net/pipermail/busybox/attachments/20040228/291720df/attachment.obj