[BusyBox] 1.00-rc2 modprobe is broken

[Phil Blundell]

I've been using the attached patch, which seems to improve matters a
bit.

The existing substring match is definitely bogus, as you point out.

p.

On Tue, 2004-08-10 at 08:21, Mike Castle wrote:
> It looks like the new mod_strcmp() is pretty broken.  I'm too tired to work
> up a patch now, but I'll supply some test cases.
> 
> I added some debugging output to mod_strcmp() to demonstrate.  I'll strip
> out most of that for the examples below.  The `=' are to point out any
> whitespace.
> 
> ./busybox modprobe -nv eth0
> mod_strcmp:eth1=eth0=
> nope
> mod_strcmp:eth0=eth0=
> nope
> mod_strcmp:char-major-81=eth0=
> nope
> 
> insmod    eth0 
> 
> 
> 
> ./busybox modprobe -nv ne2k-pci
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne.o=ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci.o=ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne3210.o=ne2k-pci=
> nope
> 
> insmod    ne2k-pci 
> 
> 
> ./busybox modprobe -nv ne2k-pci.o
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne.o=ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci.o=ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne3210.o=ne2k-pci=
> nope
> 
> insmod    ne2k-pci 
> 
> 
> ./busybox modprobe -nv /lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci.o
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne.o=/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci.o=/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci=
> nope
> mod_strcmp:/lib/modules/2.4.25-mmx/kernel/drivers/net/ne3210.o=/lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci=
> nope
> 
> insmod    /lib/modules/2.4.25-mmx/kernel/drivers/net/ne2k-pci 
> 
> 
> And even upon inspection, the code looks wrong.  It looks like it would
> want to say 'pci.o' matches 'ne2k-pci.o', which is obviously wrong.
> 
> mrc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modprobe-once-more.patch
Type: text/x-patch
Size: 561 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20040810/88d738be/attachment.bin