[BusyBox] devfsd applet

Glenn McGrath bug1 at optushome.com.au
Mon Sep 1 02:43:44 UTC 2003


>From my first look at this patch.

The way it integrates with upstream modutils, i.e. dlopen
("/lib/modutils.so",...) requiring busybox to -ldl is unacceptable IMHO.

I dont know why devfsd needs to integrate with modutils (i dont know
devfs that well), but from busybox point of view it would be better if
it could use busybox's own modutils stuff, or go without it (if
possible), or a config option to do either.

The code also has some #ifdef that will never be used such as 
OS_Solaris, OS_IRIX5, __cplusplus, and perhaps the yp_ functions you
removed could have been #ifdef'ed.

Busybox files normally include the copyright brief as well.


Glenn





More information about the busybox mailing list