[BusyBox] Re: busybox-cvs Digest, Vol 6, Issue 11

[Vladimir N. Oleynik]

Erik:

> RCS file: /var/cvs/busybox/util-linux/rdate.c,v
> retrieving revision 1.23
> retrieving revision 1.24
> diff -u -d -r1.23 -r1.24
> --- rdate.c	22 Jul 2003 08:26:03 -0000	1.23
> +++ rdate.c	12 Sep 2003 05:50:51 -0000	1.24

> +static void socket_timeout()
> +{
> +	bb_error_msg_and_die("timeout connecting to time server\n");
> +}
> +

But tail "\n" not required.


> RCS file: /var/cvs/busybox/networking/ifupdown.c,v
> retrieving revision 1.32
> retrieving revision 1.33
> diff -u -d -r1.32 -r1.33
> --- ifupdown.c	2 Sep 2003 02:36:15 -0000	1.32
> +++ ifupdown.c	12 Sep 2003 05:59:53 -0000	1.33
> @@ -1023,8 +1023,7 @@
>  static int execute_all(struct interface_defn_t *ifd, execfn *exec, const char *opt)
>  {
>  	int i;
> -	char *buf[2];
> -
> +	char *buf[100];

But execfn type is (execfn)(char *command);
I think, must declare as
char *buf;

and

> +	
> +	bb_xasprintf(buf, "run-parts /etc/network/if-%s.d", opt);

bb_xasprintf(&buf, "run-parts /etc/network/if-%s.d", opt);

> +	(*exec)(buf);


--w
vodz