[BusyBox] Bug in httpd.c
Geir Thomassen
chaos at in.fer.no
Fri Jun 20 15:25:02 UTC 2003
Waring: I am new to BusyBox.
Hello, I think the test for an unconfigured httpd is wrong in
the CVS (busybox-unstable-20030620.tar.bz2)
flg_deny_all is default 0
Geir
--- busybox/networking/httpd.c 2003-06-10 19:22:48.000000000 +0200
+++ busybox-devel/networking/httpd.c 2003-06-20 17:07:47.000000000 +0200
@@ -1354,8 +1354,8 @@
return *cur->before_colon == 'A'; /* Allow/Deny */
}
- /* if uncofigured, return 1 - access from all */
- return config->flg_deny_all;
+ /* if unconfigured, return 1 - access from all */
+ return !config->flg_deny_all;
}
#define checkPerm(null, request) checkPermIP(request)
#endif /* CONFIG_FEATURE_HTTPD_BASIC_AUTH */
More information about the busybox
mailing list