[BusyBox] ping revision 1.51

[Tim Riker]

Hmm..

I tested this and got the results I expected. It seems to be fine with
current cvs.

I would run "./busybox ping -c 1 1.2.3.4 ; echo $?" and if 1.2.3.4 was
unreachable I'd still get a 0 back.

Looked like the ping return was the issue, so I changed it. I retested
and I got the 1 return as I expected so I committed the change.

The current CVS works just as expected. Was I on drugs? I had reports
from other busybox users of the same issue. Ping returning ok even if
the ping failed.

Sorry for the hassle.

Erik Andersen wrote:
> 
> On Wed May 22, 2002 at 04:22:00PM +0400, Vladimir N. Oleynik wrote:
> > Hi.
> >
> > Please back to the revision 1.50 of the ping applet. The current patch from
> > "timr"
> > all not correct.
> >
> > 1) Function ping() not returned - called pingstats with exit(code)
> > 2) Function pingstats allways return correct exit code. Why not tested?!
> > 3) This patch not compiled witch switch of FANCY_PING config mode
> >
> > I always read current maillist. Why are brought patchs without notice
> > the author of port? :(
> 
> tim committed that change without discussing it with anyone.  I'm
> also puzzled what the problem is he was trying to solve.  I have
> reverted that change since it does not make much sense.
> 
> Tim?   What was the problem you were trying to solve?
>     http://busybox.net/cgi-bin/cvsweb/busybox/networking/ping.c.diff?r1=1.50&r2=1.51
> 
>  -Erik
> 
> --
> Erik B. Andersen             http://codepoet-consulting.com/
> --This message was written using 73% post-consumer electrons--

-- 
Tim Riker - http://rikers.org/ - TimR at Debian.org
Lineo CTO - Tim at Lineo.com - http://www.Lineo.com/
BZFlag maintainer - http://BZFlag.org/ - for fun!