[BusyBox] bug#1240: marked as done (modprobe fails when -k used)

Fri Apr 26 20:18:24 UTC 2002

Your message dated Fri, 26 Apr 2002 20:09:23 -0600
with message-id <20020427020922.GB7116 at codepoet.org>
and subject line Fixed
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Erik Andersen
(administrator, BusyBox.net bugs database)

--------------------------------------
Received: (at submit) by bugs.busybox.net; 12 Apr 2002 16:53:27 +0000
>From tschreiner at clark.edu  Fri Apr 12 10:53:27 2002
Received: from oss.lineo.com (opensource.lineo.com [64.50.107.130])
	by winder.codepoet.org (Postfix) with ESMTP id 1BB1D157BD2
	for <submit at bugs.lineo.com>; Fri, 12 Apr 2002 10:53:25 -0600 (MDT)
Received: from dns1.clark.edu (dns1.clark.edu [192.102.5.4])
	by oss.lineo.com (Postfix) with ESMTP id D454D19336C
	for <submit at bugs.lineo.com>; Fri, 12 Apr 2002 10:53:23 -0600 (MDT)
Received: from odin.clark.edu (odin.clark.edu [168.156.144.2])
	by dns1.clark.edu (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id JAA04044
	for <submit at bugs.lineo.com>; Fri, 12 Apr 2002 09:53:19 -0700
Received: by odin.clark.edu with Internet Mail Service (5.5.2653.19)
	id <GQABDJCA>; Fri, 12 Apr 2002 09:53:18 -0700
Message-ID: <4712992AAC16CA44955D27199C6B441903EE17 at odin.clark.edu>
From: "Schreiner, Torry" <tschreiner at clark.edu>
To: "'submit at bugs.lineo.com'" <submit at bugs.lineo.com>
Subject: modprobe fails when -k used
Date: Fri, 12 Apr 2002 09:53:18 -0700
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"

Package: busybox
Version: 0.60.3-pre (stable-20020411)
Severity: high

Hello, 

Using today's snapshot, busybox-stable-20020411.tar.bz2, modprobe doesn't
generate a correct command line for insmod if the -k switch is used. The
problem is in the loop that add the rest of arguments to pass into insmod.
It doesn't leave a space between the -k switch and the rest of the
arguments.  Here is a quick fix:

	sprintf(cmd, "insmod %s %s %s",
			do_syslog ? "-s" : "",
			quiet ? "-q" : "",
			autoclean ? "-k" : "");
	while (optind < argc) {
+++		strcat(cmd, " ");
		strcat(cmd, argv[optind]);
---		strcat(cmd, " ");
		optind++;
	}

Just move the strcat of the space above the strcat of the argument.

Torry Schreiner
Systems Administrator
Clark College
---------------------------------------
Received: (at 1240-done) by bugs.busybox.net; 27 Apr 2002 02:09:23 +0000
>From andersen at codepoet.org  Fri Apr 26 20:09:23 2002
Received: by winder.codepoet.org (Postfix, from userid 1000)
	id 3951B1577CF; Fri, 26 Apr 2002 20:09:23 -0600 (MDT)
Date: Fri, 26 Apr 2002 20:09:23 -0600
From: Erik Andersen <andersen at codepoet.org>
To: 1240-done at bugs.busybox.net
Subject: Fixed
Message-ID: <20020427020922.GB7116 at codepoet.org>
Reply-To: andersen at codepoet.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Operating-System: Linux 2.4.18-rmk1, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips
X-No-Junk-Mail: I do not want to get *any* junk mail.

This bug was fixed in a recent update to busybox modprobe
by Robert Griebl...

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--