[git commit] seedrng: remove unnecessary zero-filling of local variables

Denys Vlasenko vda.linux at googlemail.com
Wed Apr 27 15:09:38 UTC 2022


commit: https://git.busybox.net/busybox/commit/?id=6da9947358276d989e002c3c5c8ff2e33676ae21
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
seedrng_main                                        1323    1292     -31

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 util-linux/seedrng.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/util-linux/seedrng.c b/util-linux/seedrng.c
index 6c02b735f..c762e9ecd 100644
--- a/util-linux/seedrng.c
+++ b/util-linux/seedrng.c
@@ -103,16 +103,16 @@ static int seed_rng(uint8_t *seed, size_t len, bool credit)
 		int entropy_count;
 		int buf_size;
 		uint8_t buffer[MAX_SEED_LEN];
-	} req = {
-		.entropy_count = credit ? len * 8 : 0,
-		.buf_size = len
-	};
+	} req;
 	int random_fd, ret;
 
 	if (len > sizeof(req.buffer)) {
 		errno = EFBIG;
 		return -1;
 	}
+
+	req.entropy_count = credit ? len * 8 : 0;
+	req.buf_size = len;
 	memcpy(req.buffer, seed, len);
 
 	random_fd = open("/dev/urandom", O_RDONLY);
@@ -164,7 +164,7 @@ int seedrng_main(int argc UNUSED_PARAM, char *argv[])
 	uint8_t new_seed[MAX_SEED_LEN];
 	size_t new_seed_len;
 	bool new_seed_creditable, skip_credit = false;
-	struct timespec timestamp = { 0 };
+	struct timespec timestamp;
 	sha256_ctx_t hash;
 
 	enum {


More information about the busybox-cvs mailing list