[git commit] libarchive: treat one "FIXME: avoid seek", take 2

Denys Vlasenko vda.linux at googlemail.com
Sun May 26 11:43:06 UTC 2019


commit: https://git.busybox.net/busybox/commit/?id=cc71f79c1e5905992f4ba5cd6fe3466fe276737d
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 archival/libarchive/open_transformer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/archival/libarchive/open_transformer.c b/archival/libarchive/open_transformer.c
index 97bcc32f0..775bb580d 100644
--- a/archival/libarchive/open_transformer.c
+++ b/archival/libarchive/open_transformer.c
@@ -352,13 +352,13 @@ void* FAST_FUNC xmalloc_open_zipped_read_close(const char *fname, size_t *maxsz_
 		 *   read(4, "LF\2\1\1\0\0\0\0"...
 		 * ...and we avoided seeking on the fd! :)
 		 */
-		xstate->signature_skipped = 0;
 		image = xmalloc_read_with_initial_buf(
 			xstate->src_fd,
 			maxsz_p,
 			xmemdup(&xstate->magic, xstate->signature_skipped),
 			xstate->signature_skipped
 		);
+		xstate->signature_skipped = 0;
 	}
 
 	if (!image)


More information about the busybox-cvs mailing list